rewrite condition for clarity

uber · Aug 12, 2023 · 054aab2 · 054aab2
1 parent 7ba7009
commit 054aab2
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/nullaway/src/main/java/com/uber/nullaway/NullAway.java b/nullaway/src/main/java/com/uber/nullaway/NullAway.java
@@ -984,10 +984,12 @@ private boolean overriddenMethodReturnsNonNull(
     }
     // In JSpecify mode, for generic methods, we additionally need to check the return nullness
     // using the type parameters from the type enclosing the overriding method
-    return !config.isJSpecifyMode()
-        || GenericsChecks.getGenericMethodReturnTypeNullness(
-                overriddenMethod, overridingMethodType, state, config)
-            .equals(Nullness.NONNULL);
+    if (config.isJSpecifyMode()) {
+      return GenericsChecks.getGenericMethodReturnTypeNullness(
+              overriddenMethod, overridingMethodType, state, config)
+          .equals(Nullness.NONNULL);
+    }
+    return true;
   }
 
   @Override