Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interfaces flag with unit test #200

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    900159e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a7af37 View commit details
    Browse the repository at this point in the history
  3. Moving to a parse.go

    kliukovkin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6cc01b1 View commit details
    Browse the repository at this point in the history
  4. remove spaces

    kliukovkin committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2553835 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. update the PR according to the comments:

    - Instead of using an -interfaces flag, what do you think about having source mode read positional arguments (i.e., mockgen -source <path/to/file.go> InterfaceOne,InterfaceTwo) to align it with how reflect mode works? (If there are no positional arguments specified, we would parse all interfaces to keep backwards compatibility)
    - Instead of parsing and then dropping interfaces that aren't specified, can we simply not parse ones that aren't requested? This is similar to how the exclusion flag already works and would avoid some wasted computation.
    kliukovkin committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ec91f0c View commit details
    Browse the repository at this point in the history