-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive mode #109
Closed
Closed
Add archive mode #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
reviewed
Oct 11, 2023
README.md
Outdated
### Archive mode | ||
|
||
Archive mode generates mock interfaces from a package archive | ||
file (.a). It is enabled by using the -archive flag, the import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
file (.a). It is enabled by using the -archive flag, the import | |
file (.a). It is enabled by using the -archive flag. The import |
mockgen/model/model_gotypes.go
Outdated
} | ||
} | ||
|
||
// TODO: Struct, UnsafePointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only TODO left is UnsafePointer?
sywhang
reviewed
Oct 22, 2023
Apologies - it looks like Github closed this on my behalf for some reason. Let me attempt to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports from golang/mock#633 with an additional argument to take a list of interfaces to mock.
The archive mode allows us to generate mocks in Bazel without having to compile a package again.