Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive mode #109

Closed
wants to merge 5 commits into from
Closed

Add archive mode #109

wants to merge 5 commits into from

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Oct 11, 2023

This ports from golang/mock#633 with an additional argument to take a list of interfaces to mock.

The archive mode allows us to generate mocks in Bazel without having to compile a package again.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

@linzhp linzhp requested a review from sywhang October 11, 2023 04:06
README.md Outdated
### Archive mode

Archive mode generates mock interfaces from a package archive
file (.a). It is enabled by using the -archive flag, the import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file (.a). It is enabled by using the -archive flag, the import
file (.a). It is enabled by using the -archive flag. The import

}
}

// TODO: Struct, UnsafePointer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only TODO left is UnsafePointer?

mockgen/model/model_gotypes.go Outdated Show resolved Hide resolved
mockgen/model/model_gotypes.go Outdated Show resolved Hide resolved
@sywhang sywhang marked this pull request as draft October 23, 2023 16:51
@JacobOaks JacobOaks closed this Oct 30, 2023
@JacobOaks
Copy link
Contributor

JacobOaks commented Nov 1, 2023

Apologies - it looks like Github closed this on my behalf for some reason. Let me attempt to re-open.

@JacobOaks JacobOaks reopened this Nov 1, 2023
@JacobOaks JacobOaks closed this Nov 1, 2023
@tchung1118 tchung1118 reopened this Nov 1, 2023
@tchung1118 tchung1118 closed this Nov 1, 2023
@sywhang sywhang reopened this Nov 21, 2023
@sywhang sywhang closed this Nov 21, 2023
@linzhp linzhp reopened this Sep 10, 2024
@linzhp linzhp closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants