Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update external Go links #207

Merged
merged 2 commits into from
Jan 24, 2024
Merged

chore: Update external Go links #207

merged 2 commits into from
Jan 24, 2024

Conversation

vorobeyme
Copy link
Contributor

@vorobeyme vorobeyme commented Jan 24, 2024 •
edited by abhinav
Loading

This PR updates,

  • links from golang.org/ to go.dev/
  • github.com/golang/go/wiki links to go.dev/wiki
  • additionally, some markdown links to a section have been replaced with their corresponding .md files

Resolves #260

abhinav
abhinav approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

src/struct-embed.md
Comment on lines +34 to +36
adverse user-facing effects (see also: [Avoid Embedding Types in Public Structs](embed-public.md)).

Exception: Mutexes should not be embedded, even on unexported types. See also: [Zero-value Mutexes are Valid].

[Avoid Embedding Types in Public Structs]: #avoid-embedding-types-in-public-structs
[Zero-value Mutexes are Valid]: #zero-value-mutexes-are-valid
Exception: Mutexes should not be embedded, even on unexported types. See also: [Zero-value Mutexes are Valid](mutex-zero-value.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

sywhang
sywhang approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sywhang sywhang merged commit 6faf782 into uber-go:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinav abhinav abhinav approved these changes

@sywhang sywhang sywhang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update links to Go packages/wiki
3 participants
@vorobeyme @abhinav @sywhang