Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing panics in test activities #1374

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

3vilhamster
Copy link
Contributor

@3vilhamster 3vilhamster commented Oct 31, 2024

What changed?
I've fixed missing arguments in test worker implementations that caused tests to be flaky.

  1. Centralized additional params initialization and ensured that everything was initialized before use.
  2. Set Enable Logging to be true so tests will get all trace log messages covered.

Why?
Improve stability of tests

How did you test it?
unit tests

Potential risks

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (bcd0462) to head (7ea134a).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
internal/internal_poller_autoscaler.go 92.70% <100.00%> (ø)
internal/internal_task_handlers.go 81.44% <100.00%> (+1.73%) ⬆️
internal/internal_task_pollers.go 77.18% <100.00%> (+2.13%) ⬆️
internal/internal_worker.go 80.17% <100.00%> (+0.06%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd0462...7ea134a. Read the comment docs.

@3vilhamster 3vilhamster merged commit 847db44 into uber-go:master Oct 31, 2024
13 checks passed
@3vilhamster 3vilhamster deleted the fix-tests branch October 31, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants