Fix coverage metadata commit info #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted filesContinue to review full report in Codecov by Sentry.
|
taylanisikdemir
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx and
demirkayaender
as code owners
shijiesheng
approved these changes
Mar 22, 2024
ketsiambaku
added a commit
that referenced
this pull request
Mar 22, 2024
Fix coverage metadata commit info #1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Coverage metadata file generated by unit-test CI job was missing commit information
Switching to buildkite env vars to retrieve commit information.
Why?
The
.build/metadata.txtfile contains commit sha and timestamp of the corresponding.build/cover.outfile. This is used to integrate with 3rd party coverage tools such as Sonarqube.How did you test it?
Ran the script locally by setting buildkite env vars.
Will check how it does on master CI run after merge.