-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fol support #119
base: master
Are you sure you want to change the base?
Fol support #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drgilbert
I'd appreciate your feedback on the error messages.
Currently I've got these:
Formula at row _ is discharged more than once. (Try "unchecking" the formula.)
&
Incorrect use of resolution rule. (Did you forget to check off the resolved formula?)
} | ||
|
||
// TODO, update this to use object with named arguments. This is silly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a nice idea but would require rewriting the filter on the Carnap side to generate JSON.
I intend to look at this PR but currently I've deferred all work that can be deferred, possibly for up to a month or two, for very intense personal reasons. |
I realized when I was updating the wiki that I had forgotten to merge this branch.
It makes a small change to the tree->sequent converter which is necessary to make the FOL checker work.
Explanation from slack thread:
As before, if you try to use a formula that has already been discharged, you will get an error, which I've made more specific.