Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fol support #119

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fol support #119

wants to merge 12 commits into from

Conversation

McTano
Copy link
Collaborator

@McTano McTano commented Sep 12, 2021

I realized when I was updating the wiki that I had forgotten to merge this branch.
It makes a small change to the tree->sequent converter which is necessary to make the FOL checker work.

Explanation from slack thread:

Basically, in order to get it to work, I've made use of the 'resolved' field and checkmark, which was just decorative before.
When we instantiate a universal, we need to leave the universally quantified formula unresolved, because we might use it again. That means that the first image is correct, but the second one checks as incorrect.
correct-when-unchecked
incorrect-when-checked
Here's an example in the propositional logic:
modus-ponens-unchecked
marking row 1 as resolved makes it correct:
modus-ponens-checked

As before, if you try to use a formula that has already been discharged, you will get an error, which I've made more specific.

Screenshot 2021-09-12 154934

Copy link
Collaborator Author

@McTano McTano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drgilbert
I'd appreciate your feedback on the error messages.

Currently I've got these:

Formula at row _ is discharged more than once. (Try "unchecking" the formula.)

&

Incorrect use of resolution rule. (Did you forget to check off the resolved formula?)

@McTano McTano requested review from drgilbert and lf- September 12, 2021 23:42
}

// TODO, update this to use object with named arguments. This is silly.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a nice idea but would require rewriting the filter on the Carnap side to generate JSON.

@lf-
Copy link
Member

lf- commented Oct 2, 2021

I intend to look at this PR but currently I've deferred all work that can be deferred, possibly for up to a month or two, for very intense personal reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants