Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ListPicker icons being invisible #191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

greystate
Copy link
Contributor

Fixes #190

  • The color classes seem to have been renamed with a color- prefix (good thing) which is why the icons were invisible (white on white, as it were). Using color-red and color-blue fixes this.

  • Also, the generic .button class has was picked up by Umbraco which resulted in some spacing issues; renaming this to picker-button fixes this problem.

@Hendy Any verdict on the new class name? Should it be shorter? Something else?

Note: I have not used any of the other pickers in this solution, but I'm guessing there could be problems with some of the others too. So maybe we need to identify them and fix as well in this PR?

@thaggren
Copy link

@greystate How to get hold on an updated DLL with this fix included?

👍

@greystate
Copy link
Contributor Author

@greystate How to get hold on an updated DLL with this fix included?

I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)

If compiling your own is not an option, I guess I can make it available for you somehow...

@Hendy
Copy link
Contributor

Hendy commented Oct 30, 2018

Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...

@thaggren
Copy link

@greystate How to get hold on an updated DLL with this fix included?

I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)

If compiling your own is not an option, I guess I can make it available for you somehow...

@greystate Added your fixes manually and compiled a new DLL ... seems to be working :)

@thaggren
Copy link

Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...

@Hendy Would be great with an official updated DLL :)

@stevesuk
Copy link

stevesuk commented Dec 5, 2018

In the meantime, if you want to apply a temporary fix using only CSS, I've posted something simple to implement here:

https://our.umbraco.com/packages/backoffice-extensions/nupickers/questionssuggestions/94833-fix-for-listpicker-icons-being-invisible-191

@thaggren
Copy link

@stevesuk great "hack/fix" - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants