Fix so that a RelationLabels shows child relations as well as parent … #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for biDirectional relation type as currently it does not. Also removed usage of Umbraco legacy references in GetRelationTypes method and refactored to use RelationsService
|
Hi @Jeavon I don't suppose you can recall the use-case for checking for bi-directional relations ? (the parent is always the picked item, and the child always the context of the picker regardless of the relation direction - I'm making the assumption that the relation labels will always be on the picked item - or is this to take into account relations created though another mechanism ?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for biDirectional relation type as currently it does not.
Also removed usage of Umbraco legacy references in GetRelationTypes method and refactored to use RelationsService