-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH4typ:0.0.1 #1572
CH4typ:0.0.1 #1572
Conversation
This is the first time I created a packet. I may not cope with everything right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for the submission. Here are a few things to change before it can be merged, but your package generally looks good.
@@ -0,0 +1,7 @@ | |||
[package] | |||
name = "CH4typ" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to to use lower-kebab-case for your package name. The current name would become ch-4-typ
, but (if I remember my chemistry class correctly) that would ruin the joke in the name. Maybe you can change the name entirely if you are not satisfied with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to ch-4-typ
because it looks like the isomer of "chtyp".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some thought, I might probably try typsium
instead.
Co-authored-by: Ana Gelez <[email protected]>
If I change my package name, should I open a new pr for better maintenance or just use this one?
|
You can re-use this PR. Edit: I just saw your other PR, which is fine too. I'll let you decide which one you want to keep. |
Close PR and reopen in #1635 (comment) |
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE