Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH4typ:0.0.1 #1572

Closed
wants to merge 19 commits into from
Closed

CH4typ:0.0.1 #1572

wants to merge 19 commits into from

Conversation

tryptophawa
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description: Explain what the package does and why it's useful.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE

@typst-package-check typst-package-check bot changed the title CH4typ CH4typ:0.0.1 Jan 14, 2025
@typst-package-check typst-package-check bot added the new A new package submission. label Jan 14, 2025
@tryptophawa
Copy link
Contributor Author

This is the first time I created a packet. I may not cope with everything right.

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for the submission. Here are a few things to change before it can be merged, but your package generally looks good.

packages/preview/CH4typ/0.0.1/typst.toml Outdated Show resolved Hide resolved
@@ -0,0 +1,7 @@
[package]
name = "CH4typ"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to to use lower-kebab-case for your package name. The current name would become ch-4-typ, but (if I remember my chemistry class correctly) that would ruin the joke in the name. Maybe you can change the name entirely if you are not satisfied with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to ch-4-typ because it looks like the isomer of "chtyp".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some thought, I might probably try typsium instead.

@tryptophawa
Copy link
Contributor Author

If I change my package name, should I open a new pr for better maintenance or just use this one?

一定不是我git用的不好 Must not be my bad git skills.

@elegaanz
Copy link
Member

elegaanz commented Jan 27, 2025

You can re-use this PR.

Edit: I just saw your other PR, which is fine too. I'll let you decide which one you want to keep.

@tryptophawa
Copy link
Contributor Author

Close PR and reopen in #1635 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants