Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-my-euxfel:1.0.0 #1563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

oh-my-euxfel:1.0.0 #1563

wants to merge 1 commit into from

Conversation

JamesWrigley
Copy link

I am submitting

  • a new package
  • an update for a package

Description: the package provides a template for presentations with the European XFEL logo and style.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Note: the thumbnail.png and theme-demo.png files are very slightly different in that the header is missing from the title slide in thumbnail.png. This is because I compiled the file for the thumbnail under Typst 0.12 and for some reason that broke the title slide header 🤔 I'll look into it later, but I don't think it needs to block registration.

@typst-package-check typst-package-check bot added the new A new package submission. label Jan 13, 2025
@JamesWrigley
Copy link
Author

Not sure why the preview job is stuck 👀 Locally presentation.typ builds in less than a second.

@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024 James Wrigley
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (c) 2024 James Wrigley
Copyright (c) 2024-2025 James Wrigley

@@ -0,0 +1,31 @@
# An XFEL Polylux theme

This is a [Polylux](https://polylux.dev/book/) theme for [European
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polylux is not very actively maintained and the latest version is using deprecated functions. I would rather not merge a package that reports deprecation warnings as they will become hard errors with the next Typst release. I contacted the Polylux maintainer to ask them to make a new release to fix that, but it may take some time before they actually do it. If you would like to have your package released rapidly, I would suggest switching to another presentation package, like touying which should have a similar API and that is more actively maintained.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I wasn't aware of that... I'll have a go at switching it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I already got an answer from them and they said they would make a release to fix this issue soon. So if you prefer to wait a few days, it should not be that long.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polylux 0.4.0 was just released, updating it should fix the issues.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, I forgot about this 😅 I have heard good things about touying though so I'll have another look at that before proceeding, will try to finish this this week.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is the official logo and that you didn't design it yourself. If that's true, can you please add a note in your README and/or LICENSE file stating under which license it is distributed?

@elegaanz
Copy link
Member

And about the CI never ending, it is just that it ran out of disk space and crashed in the middle of the checks. I should migrate it to a more powerful server, but this is "normal" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants