-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oh-my-euxfel:1.0.0 #1563
base: main
Are you sure you want to change the base?
oh-my-euxfel:1.0.0 #1563
Conversation
Not sure why the preview job is stuck 👀 Locally |
@@ -0,0 +1,21 @@ | |||
MIT License | |||
|
|||
Copyright (c) 2024 James Wrigley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2024 James Wrigley | |
Copyright (c) 2024-2025 James Wrigley |
@@ -0,0 +1,31 @@ | |||
# An XFEL Polylux theme | |||
|
|||
This is a [Polylux](https://polylux.dev/book/) theme for [European |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polylux is not very actively maintained and the latest version is using deprecated functions. I would rather not merge a package that reports deprecation warnings as they will become hard errors with the next Typst release. I contacted the Polylux maintainer to ask them to make a new release to fix that, but it may take some time before they actually do it. If you would like to have your package released rapidly, I would suggest switching to another presentation package, like touying
which should have a similar API and that is more actively maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, I wasn't aware of that... I'll have a go at switching it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I already got an answer from them and they said they would make a release to fix this issue soon. So if you prefer to wait a few days, it should not be that long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polylux 0.4.0 was just released, updating it should fix the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, I forgot about this 😅 I have heard good things about touying though so I'll have another look at that before proceeding, will try to finish this this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is the official logo and that you didn't design it yourself. If that's true, can you please add a note in your README and/or LICENSE file stating under which license it is distributed?
And about the CI never ending, it is just that it ran out of disk space and crashed in the middle of the checks. I should migrate it to a more powerful server, but this is "normal" for now. |
I am submitting
Description: the package provides a template for presentations with the European XFEL logo and style.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSENote: the
thumbnail.png
andtheme-demo.png
files are very slightly different in that the header is missing from the title slide inthumbnail.png
. This is because I compiled the file for the thumbnail under Typst 0.12 and for some reason that broke the title slide header 🤔 I'll look into it later, but I don't think it needs to block registration.