Add Index Checker annotations

.travis.yml

@@ -0,0 +1,4 @@
+language: java
+sudo: false
+script:
+  - travis_wait mvn compile

pom.xml

@@ -59,31 +59,78 @@
             <version>4.11</version>
             <scope>test</scope>
         </dependency>
+        <!-- Annotations from the Checker Framework: nullness, interning, locking, ... -->
+        <dependency>
+            <groupId>org.checkerframework</groupId>
+            <artifactId>checker-qual</artifactId>
+            <version>2.5.1</version>
+        </dependency>
+        <dependency>
+            <groupId>org.checkerframework</groupId>
+            <artifactId>jdk8</artifactId>
+            <version>2.5.1</version>
+        </dependency>
     </dependencies>
 
     <distributionManagement>
         <snapshotRepository>
           <id>ossrh</id>
           <url>https://oss.sonatype.org/content/repositories/snapshots</url>
         </snapshotRepository>
-    </distributionManagement>    
-    
+    </distributionManagement>
+
     <build>
         <testSourceDirectory>src/test/java</testSourceDirectory>
 
         <plugins>
 
             <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.7.0</version>
                 <configuration>
-                    <source>${project.source.level}</source>
-                    <target>${project.target.level}</target>
-                    <encoding>${project.build.sourceEncoding}</encoding>                
+                    <source>1.8</source>
+                    <target>1.8</target>
+                    <compilerArguments>
+                        <Xmaxerrs>10000</Xmaxerrs>
+                        <Xmaxwarns>10000</Xmaxwarns>
+                    </compilerArguments>
+                    <annotationProcessorPaths>
+                        <path>
+                            <groupId>org.checkerframework</groupId>
+                            <artifactId>checker</artifactId>
+                            <version>2.5.1</version>
+                        </path>
+                    </annotationProcessorPaths>
+                    <annotationProcessors>
+                        <!-- Add all the checkers you want to enable here -->
+                        <annotationProcessor>${checkerframework.checkers}</annotationProcessor>
+                    </annotationProcessors>
+                    <compilerArgs>
+                        <arg>-AprintErrorStack</arg>
+                        <!-- location of the annotated JDK, which comes from a Maven dependency -->
+                        <arg>-Xbootclasspath/p:${annotatedJdk}</arg>
+                        <arg>-AskipDefs=Test</arg>
+                        <arg>${checkerframework.extraargs}</arg>
+                        <arg>${checkerframework.extraargs2}</arg>
+                        <!-- Uncomment the following line to turn type-checking warnings into errors. -->
+                        <!-- <arg>-Awarns</arg> -->
+                    </compilerArgs>
                 </configuration>
             </plugin>
 
+            <plugin>
+                <!-- This plugin will set properties values using dependency information -->
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>properties</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
@@ -155,9 +202,15 @@
     </reporting>
 
     <properties>
+        <project.source.level>1.8</project.source.level>
+        <project.target.level>1.8</project.target.level>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <project.source.level>1.6</project.source.level>
-        <project.target.level>1.6</project.target.level>
+        <!-- These properties will be set by the Maven Dependency plugin -->
+        <annotatedJdk>${org.checkerframework:jdk8:jar}</annotatedJdk>
+        <!-- These properties are here for convenience when modifying the build from the command line -->
+        <checkerframework.checkers>org.checkerframework.checker.index.IndexChecker</checkerframework.checkers>
+        <checkerframework.extraargs></checkerframework.extraargs>
+        <checkerframework.extraargs2></checkerframework.extraargs2>
     </properties>
 
     <profiles>
@@ -225,6 +278,19 @@
                         </executions>
                     </plugin>
 
+                    <plugin>
+                        <!-- This plugin will set properties values using dependency information -->
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-dependency-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <goals>
+                                    <goal>properties</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+
                 </plugins>
             </build>
         </profile>

src/main/java/org/jfree/chart/ChartColor.java

@@ -45,6 +45,9 @@
 
 package org.jfree.chart;
 
+import org.checkerframework.checker.index.qual.*;
+import org.checkerframework.common.value.qual.*;
+
 import java.awt.Color;
 import java.awt.Paint;
 
@@ -146,7 +149,7 @@ public ChartColor(int r, int g, int b) {
      *
      * @return An array of objects with the {@code Paint} interface.
      */
-    public static Paint[] createDefaultPaintArray() {
+    public static Paint @ArrayLen(34) [] createDefaultPaintArray() {
 
         return new Paint[] {
             new Color(0xFF, 0x55, 0x55),

src/main/java/org/jfree/chart/ChartFrame.java

@@ -2,7 +2,7 @@
  * JFreeChart : a free chart library for the Java(tm) platform
  * ===========================================================
  *
- * (C) Copyright 2000-2016, by Object Refinery Limited and Contributors.
+ * (C) Copyright 2000-2018, by Object Refinery Limited and Contributors.
  *
  * Project Info:  http://www.jfree.org/jfreechart/index.html
  *
@@ -27,17 +27,11 @@
  * ---------------
  * ChartFrame.java
  * ---------------
- * (C) Copyright 2001-2008, by Object Refinery Limited and Contributors.
+ * (C) Copyright 2001-2018, by Object Refinery Limited and Contributors.
  *
  * Original Author:  David Gilbert (for Object Refinery Limited);
  * Contributor(s):   -;
  *
- * Changes
- * -------
- * 22-Nov-2001 : Version 1 (DG);
- * 08-Jan-2001 : Added chartPanel attribute (DG);
- * 24-May-2002 : Renamed JFreeChartFrame --> ChartFrame (DG);
- *
  */
 
 package org.jfree.chart;
@@ -75,7 +69,7 @@ public ChartFrame(String title, JFreeChart chart) {
     public ChartFrame(String title, JFreeChart chart, boolean scrollPane) {
         super(title);
         setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
-        this.chartPanel = new ChartPanel(chart);
+        this.chartPanel = new ChartPanel(chart, false);
         if (scrollPane) {
             setContentPane(new JScrollPane(this.chartPanel));
         }