Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lub annotations on anonymous constructors #6837

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

smillst
Copy link
Member

@smillst smillst commented Oct 3, 2024

(This only fixes the anonymous test case in #6823.)

@msridhar
Copy link
Contributor

msridhar commented Oct 3, 2024

This change LGTM and looks simple enough but I don't really know this code; probably @mernst should review.

@msridhar msridhar requested a review from mernst October 3, 2024 16:56
@msridhar msridhar assigned mernst and unassigned msridhar Oct 3, 2024
mernst
mernst previously approved these changes Oct 3, 2024
@mernst mernst removed their assignment Oct 4, 2024
@mernst mernst enabled auto-merge (squash) October 4, 2024 20:40
@mernst mernst merged commit d967ea3 into typetools:master Oct 5, 2024
36 checks passed
@mernst mernst deleted the issue6823-anonymous branch October 5, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants