Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated multiSearch perform type in doctype to match actual type #74

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

angus-mcritchie
Copy link
Contributor

Change Summary

When using the multisearch I put a string in the first argument instead of an array as that's what my IDE was saying it required.

I got an error saying it required an array.

Caused by a type mismatch in the docblock and the actual php type in the function parameters.

Very small change :)

PR Checklist

@jasonbosco
Copy link
Member

Thank you!

Copy link

@gnovaro gnovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@jasonbosco jasonbosco merged commit 313d934 into typesense:master Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants