feat(abg)!: replace data class perks by code generation in bindings #1644
+1,324
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
fcb93fe
to
f2e6c05
Compare
Vampire
force-pushed
the
vampire/versioned-routes
branch
from
6e0c383
to
05942ab
Compare
This was referenced Sep 8, 2024
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f2e6c05
to
f9bff8a
Compare
Vampire
changed the base branch from
vampire/versioned-routes
to
vampire/binding-version-v2
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
26ff564
to
915be83
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
5b756f4
to
a485fe4
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
915be83
to
01e7a87
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
a485fe4
to
6c58c0d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
01e7a87
to
781eb1b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
6c58c0d
to
66b9afd
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
781eb1b
to
248813f
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
66b9afd
to
f8e466f
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
248813f
to
a5da3b1
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
f8e466f
to
eb02b5a
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
a5da3b1
to
f58ac6b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
eb02b5a
to
36a0a91
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f58ac6b
to
f11c738
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
36a0a91
to
8895541
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f11c738
to
5e87ccb
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
8895541
to
4281b5d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
5e87ccb
to
c89a7e1
Compare
krzema12
reviewed
Oct 17, 2024
| - The `toString` method will work like before. | ||
| - Destructuring assignments are not possible anymore as this will likely break silently or during | ||
| compilation when action owners add new inputs in between existing ones. | ||
| - The `clone` method will work like before, just that now usage of named arguments is enforced |
There was a problem hiding this comment.
Did you mean
Suggested change
| - The `clone` method will work like before, just that now usage of named arguments is enforced | |
| - The `copy` method will work like before, just that now usage of named arguments is enforced |
?
| - The `equals` method will work like before. | ||
| - The `hashCode` method will work like before. | ||
| - The `toString` method will work like before. | ||
| - Destructuring assignments are not possible anymore as this will likely break silently or during |
There was a problem hiding this comment.
I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
There was a problem hiding this comment.
My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄
There was a problem hiding this comment.
Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629