Fix typing of related manager methods #2439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
force-pushed
the
fix-related-managers
branch
3 times, most recently
from
8f45820
to
2dd86ee
Compare
Looking at the [related manager documentation][0] it isn't very clear that the `bulk` argument only applies to `RelatedManager` and the `through_defaults` argument only applies to `ManyRelatedManager`. Based on the [related descriptors source][1], the following changes have been made in this commit: - The `bulk` argument has been added to `.clear()` and `.aclear()` for `RelatedManager` - The `bulk` argument has been removed from all methods of `ManyRelatedManager` - Additional methods using `through_defaults` have been added to `ManyRelatedManager`. - Updated typing of `through_defaults` to `Mapping[str, Any] | None` [0]: https://docs.djangoproject.com/en/stable/ref/models/relations/ [1]: https://github.com/django/django/blob/042b381e2e37c0c37b8a8f6cc9947f1a2ebfa0dd/django/db/models/fields/related_descriptors.py
ngnpope
force-pushed
the
fix-related-managers
branch
from
2dd86ee
to
46bfbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the related manager documentation it isn't very clear that the
bulkargument only applies toRelatedManagerand thethrough_defaultsargument only applies toManyRelatedManager.Based on the related descriptors source, the following changes have been made in this commit:
bulkargument has been added to.clear()and.aclear()forRelatedManagerbulkargument has been removed from all methods ofManyRelatedManagerthrough_defaultshave been added toManyRelatedManager.