Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2413 -- update ModelAdmin.log_FOO method signatures #2414

Merged

Conversation

sergei-maertens
Copy link
Contributor

Renamed the 'object' parameter to 'obj' to be consistent with the runtime implementation.

Verified against Django 4.2 and the main branch.

Related issues

Closes #2413

@sobolevn
Copy link
Member

please, remove

 note: unused allowlist entry django.contrib.admin.ModelAdmin.log_addition
note: unused allowlist entry django.contrib.admin.ModelAdmin.log_change
note: unused allowlist entry django.contrib.admin.ModelAdmin.log_deletion
note: unused allowlist entry django.contrib.admin.options.ModelAdmin.log_addition
note: unused allowlist entry django.contrib.admin.options.ModelAdmin.log_change
note: unused allowlist entry django.contrib.admin.options.ModelAdmin.log_deletion
note: unused allowlist entry django.contrib.gis.admin.ModelAdmin.log_addition
note: unused allowlist entry django.contrib.gis.admin.ModelAdmin.log_change
note: unused allowlist entry django.contrib.gis.admin.ModelAdmin.log_deletion

from https://github.com/typeddjango/django-stubs/tree/master/scripts/stubtest

Renamed the 'object' parameter to 'obj' to be consistent with the
runtime implementation.

Verified against Django 4.2 and the main branch.
@sergei-maertens
Copy link
Contributor Author

neat - I missed that part in the contributing guidelines! I've amended the commit/PR.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@sobolevn sobolevn merged commit a98e7e7 into typeddjango:master Oct 22, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Admin: log_addition/log_change/log_deletion have incorrect parameter names
2 participants