Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ModelBase.objects declaration to Model.objects, for mypy 1.5.0 #1649

Closed
wants to merge 2 commits into from
Closed

Move ModelBase.objects declaration to Model.objects, for mypy 1.5.0 #1649

wants to merge 2 commits into from

Commits on Sep 2, 2023

  1. Move ModelBase.objects declaration to Model.objects, for mypy 1.5.0 

    mypy 1.5.0 was fixed to understand that metaclass attributes take
precedence over attributes in the regular class.  So we need to
declare `objects` in the regular class to allow it to be overridden in
subclasses.

Fixes typeddjango#1648.

Signed-off-by: Anders Kaseorg <[email protected]>
    @andersk
    andersk committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    fc3ef75 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Merge branch 'master' into mypy-1.5

    @sobolevn
    sobolevn authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b246cdd View commit details
    Browse the repository at this point in the history