fix(Options): pk cannot be None #1635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `Options.pk` typing to always be a `Field`
sobolevn
reviewed
Jul 31, 2023
There was a problem hiding this comment.
It is set to None by default: https://github.com/django/django/blob/22b0b73c7732ba67db4e69fd9fa75aad84c8e5c4/django/db/models/options.py#L133
So, Options(meta).pk is None, it is only set to not-None after setup_pk: https://github.com/django/django/blob/22b0b73c7732ba67db4e69fd9fa75aad84c8e5c4/django/db/models/options.py#L370
|
I think that I will close this PR, I hope that my explanation is good enough :) Anyways, thanks a lot for taking your time to contribute! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
Options.pktyping to always be aFieldI have made things!
Hello, I am no Django expert so I may be wrong, but it seems to me a Model always define a primary key (either explicitly or implicitly), which means
Model._meta.pkalways references aFieldRelated issues
No issue, I can create one if needs be .