Fix crash when FK references unknown 'app_label' #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
approved these changes
Jan 25, 2023
| content: | | ||
| from django.db import models | ||
| class InstalledModel(models.Model): | ||
| non_installed = models.ForeignKey( # E: Cannot find model 'not_installed.NonInstalledModel' referenced in field 'non_installed' |
There was a problem hiding this comment.
Is it also possible to ignore this error using a # type: ignore comment?
There was a problem hiding this comment.
I tested it and indeed it works.
There was a problem hiding this comment.
I didn't think mypy supported suppressing any errors produced by a plugin (yet?)
Refs:
There was a problem hiding this comment.
I thought the same. Yet the test passes successfully with the following diff:
diff --git a/tests/typecheck/fields/test_related.yml b/tests/typecheck/fields/test_related.yml
index 7e9758ae..cc863373 100644
--- a/tests/typecheck/fields/test_related.yml
+++ b/tests/typecheck/fields/test_related.yml
@@ -940,6 +940,6 @@
content: |
from django.db import models
class InstalledModel(models.Model):
- non_installed = models.ForeignKey( # E: Cannot find model 'not_installed.NonInstalledModel' referenced in field 'non_installed'
+ non_installed = models.ForeignKey( # type: ignore
"not_installed.NonInstalledModel", on_delete=models.CASCADE
)I'm not complaining 😆
There was a problem hiding this comment.
How interesting, have to compare how this error is emitted versus the one that couldn't be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Plugin previously crashed running the provided test case, now it yields an intended error message instead.
Related issues
Ref: #1312