Merge pull request #30 from tylim88/new-features

@firebase/rules-unit-testing is now supported and tested.
tylim88 · Apr 13, 2022 · cd8c59b · cd8c59b
2 parents 713c085 + 7b84c56
commit cd8c59b
Show file tree

Hide file tree

Showing 42 changed files with 500 additions and 175 deletions.
diff --git a/.github/workflows/github-actions.yml b/.github/workflows/github-actions.yml
@@ -11,6 +11,7 @@ jobs:
           node-version: '16.14'
           cache: 'npm'
           cache-dependency-path: '**/package-lock.json'
+      - run: npm i -g firebase-tools
       - run: npm i
       - run: npm run lint --fix
       - run: npm run pretty-quick
@@ -19,8 +20,8 @@ jobs:
           PROJECT_ID: ${{ secrets.PROJECT_ID }}
       - run: npm run build
       - run: npm run link
-      - run: npm run e-tsc
-      - run: npm run e-test
+      - run: npm run b-tsc
+      - run: npm run b-test
         env:
           PROJECT_ID: ${{ secrets.PROJECT_ID }}
       - uses: codecov/codecov-action@v2
@@ -35,6 +36,7 @@ jobs:
           cache: 'npm'
           cache-dependency-path: '**/package-lock.json'
           registry-url: 'https://registry.npmjs.org'
+      - run: npm i -g firebase-tools
       - run: npm i
       - run: npm run build
       - run: npm publish

diff --git a/.gitignore b/.gitignore
@@ -20,6 +20,8 @@
 /.config
 .env
 /.parcel-cache
+firebase-debug.log
+firestore-debug.log
 
 npm-debug.log*
 yarn-debug.log*

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -5,4 +5,4 @@ npm run lint --fix
 npm run pretty-quick
 npm run build 
 npm run d-test
-npm run d-e-test
+npm run d-b-test
diff --git a/.npmignore b/.npmignore
@@ -16,7 +16,6 @@
 .gitignore
 .npmignore
 note.txt
-V0Doc.md
 
 # config file
 jest.config.js
@@ -39,4 +38,7 @@ tsconfig.prod.json
 
 # misc
 CHANGELOG.md
-package-lock.json
+package-lock.json
+firebase-debug.log
+firestore-debug.log
+/firebase.json
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # HISTORY
 
+## v1.2.0 13-April-22
+
+- @firebase/rules-unit-testing is now supported and tested.
+
 ## v1.2.0 12-April-22
 
 - gradually add support for @firebase/rules-unit-testing, stage 1

diff --git a/README.md b/README.md
@@ -109,10 +109,11 @@
 <a href="https://firelordjs.com/quick_start" target="_blank"><strong>Documentation</strong></a>
 </div>
 
-# Note
+<br/>
+
+support [@firebase/rules-unit-testing](https://www.npmjs.com/package/@firebase/rules-unit-testing)
 
-1. V1 rewrite from scratch using Firestore V9 API and is better than V0 by a huge margin.
-2. V1 is not compatible with V0, the old V0 Documentation can be found [here](https://github.com/tylim88/Firelordjs/V0Doc.md).
+The development code, built code and published code are all tested in ci.
 
 ## Related Projects
 

diff --git a/V0Doc.md b/V0Doc.md
diff --git a/codeForDoc/firebase.json b/codeForDoc/firebase.json
@@ -0,0 +1,10 @@
+{
+  "emulators": {
+    "firestore": {
+      "port": 8080
+    },
+    "ui": {
+      "enabled": true
+    }
+  }
+}
diff --git a/codeForDoc/package.json b/codeForDoc/package.json
@@ -4,8 +4,9 @@
 	"description": "test published Firelordjs",
 	"main": "index.js",
 	"scripts": {
-		"reinstall": "(rm -rf node_modules || true) && (rm package-lock.json || true) && npm i",
-		"test": "rm -rf coverage && jest --forceExit"
+		"uninstall": "rm -rf node_modules && rm -rf package-lock.json",
+		"reinstall": "npm run uninstall && npm i",
+		"test": "firebase emulators:exec --only firestore \"rm -rf coverage && jest --forceExit\""
 	},
 	"author": "",
 	"license": "ISC",

diff --git a/codeForDoc/batch.ts → codeForDoc/src/batch.ts b/codeForDoc/batch.ts → codeForDoc/src/batch.ts
diff --git a/codeForDoc/dataType.ts → codeForDoc/src/dataType.ts b/codeForDoc/dataType.ts → codeForDoc/src/dataType.ts
diff --git a/codeForDoc/defineYourType/firelord.ts → codeForDoc/src/defineYourType/firelord.ts b/codeForDoc/defineYourType/firelord.ts → codeForDoc/src/defineYourType/firelord.ts
diff --git a/codeForDoc/defineYourType/getFirelord.ts → codeForDoc/src/defineYourType/getFirelord.ts b/codeForDoc/defineYourType/getFirelord.ts → codeForDoc/src/defineYourType/getFirelord.ts
diff --git a/codeForDoc/deleteField.ts → codeForDoc/src/deleteField.ts b/codeForDoc/deleteField.ts → codeForDoc/src/deleteField.ts
diff --git a/codeForDoc/deleteFieldFirelord.ts → codeForDoc/src/deleteFieldFirelord.ts b/codeForDoc/deleteFieldFirelord.ts → codeForDoc/src/deleteFieldFirelord.ts
diff --git a/codeForDoc/dist.test.ts → codeForDoc/src/dist.test.ts b/codeForDoc/dist.test.ts → codeForDoc/src/dist.test.ts
@@ -95,8 +95,7 @@ describe('dist files test', () => {
 					unsub()
 					done()
 				},
-				// @ts-expect-error
-				{ includeMetadataChanges: false },
+				() => {},
 				{ includeMetadataChanges: true }
 			)
 		})

diff --git a/codeForDoc/documentIdFirelord.ts → codeForDoc/src/documentIdFirelord.ts b/codeForDoc/documentIdFirelord.ts → codeForDoc/src/documentIdFirelord.ts
diff --git a/codeForDoc/get.ts → codeForDoc/src/get.ts b/codeForDoc/get.ts → codeForDoc/src/get.ts
diff --git a/codeForDoc/getFirelord.ts → codeForDoc/src/getFirelord.ts b/codeForDoc/getFirelord.ts → codeForDoc/src/getFirelord.ts
diff --git a/codeForDoc/init.ts → codeForDoc/src/init.ts b/codeForDoc/init.ts → codeForDoc/src/init.ts
diff --git a/codeForDoc/limitFirelord.ts → codeForDoc/src/limitFirelord.ts b/codeForDoc/limitFirelord.ts → codeForDoc/src/limitFirelord.ts
diff --git a/codeForDoc/metatype.ts → codeForDoc/src/metatype.ts b/codeForDoc/metatype.ts → codeForDoc/src/metatype.ts
diff --git a/codeForDoc/operations.ts → codeForDoc/src/operations.ts b/codeForDoc/operations.ts → codeForDoc/src/operations.ts
diff --git a/codeForDoc/possiblyUndefined.ts → codeForDoc/src/possiblyUndefined.ts b/codeForDoc/possiblyUndefined.ts → codeForDoc/src/possiblyUndefined.ts
diff --git a/codeForDoc/query.ts → codeForDoc/src/query.ts b/codeForDoc/query.ts → codeForDoc/src/query.ts
diff --git a/codeForDoc/queryAndOnSnapshot.ts → codeForDoc/src/queryAndOnSnapshot.ts b/codeForDoc/queryAndOnSnapshot.ts → codeForDoc/src/queryAndOnSnapshot.ts