SCSS calculation fixes #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 14, 2012 16:22
- Fixed bug where the overall column width was shadowed by a parameter name. - Removed the (unnecessary) second parameter to column(). The value was used to calculate the ratio of $total-width/$calculated-width for fluid-width purposes, and therefore should always use the global $column count.
The gridsystem-ratio() function calculates the ratio of the user-specified $total-width, to the calculated grid width. This ratio was used in every width calculation, and rewriting the calculations using this gridsystem-ratio() made their purposes much more obvious.
gridsystem-width() already calculates the width with the outer margin included. Adding the gutter again makes the width of the row too large.
An expression in the column width calculation was mathematically equivalent to the value calculated by gridsystem-width(), so I replaced it with a call to that function.
Just as in the width calculation for column(), the push and pull mixins contained an expression that was mathematically equivalent to the value calculated by gridsystem-width(), so I replaced it with a call to that function.
The previous formula for calculating push/pull margins was incorrect. The correct behavior is for the push/pull margin of $x to be equivalent to the width of column($x) plus half of the gutter. The formula could be simplified further, but I feel that writing it this way emphesises the relationship to the column width formula.
It didn't take changing default values into account. I updated it to recalculate the "default width" every time.
- Using 960.gs as a benchmark for what the column widths that are generated should be. - Ensure that the row widths are calculated correctly in relation to the column widths.
|
👍 |
1 similar comment
|
👍 |
|
|
|
I created SCSS only repo of Semantic.gs with those changes, because I didn't want to wait for ages. All rights reserverd for bhcarpenter (who done this changes and send them here) and for tylertate who is author of Semantic.gs. I only merged changes with newest version of Semantic.gs and remove unnecessary things (I didn't merged tests also, because I don't use them at all). |
|
As already to @Nosenation asked. Any ideas how to accomplish this changes with fluid layouts? It breaks if |
|
@yckart Problem is fixed in my repo. 😄 |
|
This is awesome as have been looking for the fixes for the exact issue, thanks guys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits updates the SCSS version. It includes the following:
Please feel free to discuss and ask questions.