ponyfill Map and WeakMap for older clients #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwales1
force-pushed
the
ponyfill-maps
branch
from
efac5a3
to
b424587
Compare
|
The choice is obviously yours, but doesn't this just increase the bundle size for everyone when only needed by a few? http://kangax.github.io/compat-table/es6/#test-Map I've been using https://polyfill.io for these things, seems to work quite well. The problem I saw was because they don't polyfill by default if the UA is unknown (in my case, and older Samsung browser), but you can change that behavior. |
|
@oscar-b Yeah good call. The bundle increase is quite significant too. I am going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #143