-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of Map and WeakMap #143
Comments
@oscar-b I don't think Map is necessary for keeping track of listeners and refs. Could use a different approach. The WeakMap is used because React does not have a unique identifier for each component and |
@qwales1 Older versions of Chrome (v34) used in Samsung phones from 2014 branded as Samsung Browser. |
@oscar-b does the error reporting tell you what specifically its blowing up on? Is it |
I guess it's: |
@oscar-b Yes sorry that is what I was asking. Could add |
I would either refactor to use regular object/array or add documentation about compatibility and use of something like polyfill.io. |
Is the use of Map and WeakMap necessary? I recently added error tracking to our site and found out that old clients barf on these requirements. The alternative is of course to polyfill, but that should probably be documented.
The text was updated successfully, but these errors were encountered: