fix: Warn, don't error, when generating git commit messages for unkno…

…wn states
twpayne · Jan 25, 2025 · 309d7fd · 309d7fd
1 parent ab4bdaa
commit 309d7fd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/assets/templates/COMMIT_MESSAGE.tmpl b/assets/templates/COMMIT_MESSAGE.tmpl
@@ -4,23 +4,23 @@
 {{ if and (eq .X 'A') (eq .Y '.') -}}Add {{ .Path | targetRelPath }}
 {{ else if and (eq .X 'D') (eq .Y '.') -}}Remove {{ .Path | targetRelPath }}
 {{ else if and (eq .X 'M') (eq .Y '.') -}}Update {{ .Path | targetRelPath }}
-{{ else }}{{with (printf "unsupported XY: %q" (printf "%c%c" .X .Y)) }}{{ fail . }}{{ end }}
+{{ else }}{{ warnf "unsupported XY: %c%c" .X .Y }}
 {{ end }}
 {{- end -}}
 
 {{- range .RenamedOrCopied -}}
 {{ if and (eq .X 'R') (eq .Y '.') }}Change attributes of {{ .Path | targetRelPath }}
 {{ else if and (eq .X 'C') (eq .Y '.') -}}Copy {{ .OrigPath | targetRelPath }} to {{ .Path | targetRelPath }}
-{{ else }}{{with (printf "unsupported XY: %q" (printf "%c%c" .X .Y)) }}{{ fail . }}{{ end }}
+{{ else }}{{ warnf "unsupported XY: %c%c" .X .Y }}
 {{ end }}
 {{- end -}}
 
 {{- range .Unmerged -}}
-{{ fail "unmerged files" }}
+{{ warnf "unmerged files" }}
 {{- end -}}
 
 {{- range .Untracked -}}
-{{ fail "untracked files" }}
+{{ warnf "untracked files" }}
 {{- end -}}
 
 {{- end -}}
diff --git a/internal/cmd/testdata/scripts/issue3344.txtar b/internal/cmd/testdata/scripts/issue3344.txtar
@@ -0,0 +1,13 @@
+[!exec:git] skip 'git not found in $PATH'
+
+mkgitconfig
+
+exec chezmoi init
+
+# test that chezmoi generate git-commit-message warns about untracked files
+cp golden/.file $CHEZMOISOURCEDIR
+exec chezmoi generate git-commit-message
+stderr 'chezmoi: warning: untracked files'
+
+-- golden/.file --
+# contents of .file