Actually run in bzlmod mode on CI #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
ci-fix-bzlmod
branch
3 times, most recently
from
58140e2
to
d88910a
Compare
The `%workspace%` placeholder is simply expanded to a windows path like `c:/my/project`. The resulting URI looks like this: `file:c:/my/project`. This is not a valid file URI and the `URI.getPath()` method returns `null` which leads to a NPE in Bazel. Using a triple slash works around this problem, although the path starts with a doubled slash on unix systems now.
This should be the last file imported, so that the user is able to override any settings before.
The jobs are currently failing since we are not using GHC version specific snapshots and json files.
Otherwise Bazel would detect the Visual Studio compiler and use it.
avdv
force-pushed
the
ci-fix-bzlmod
branch
2 times, most recently
from
6997489
to
6cc9e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that we actually never ran rules_haskell_test in bzlmod mode on CI.
This was due to a missing space character in the inline bash script of the workflow.yml file which would always yield
false.Additionally, we need to ensure that we can actually override Bazel settings using
.bazelrc.localfile which we are using on CI.Note, this PR disables CI jobs for GHC 9.4 with bzlmod for now. The reason is that we would need to find a way to read a different stack_snapshot and json file depending on the GHC version. This is tracked here: #2006
For Windows, we need to work around a path problem passing when
file:%workspace%/registrywhich is expanded to an invalid file: URI without a path component. See bazelbuild/bazel#20015