Use TH-enabled build, remove custom miso #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we run into parcel-bundler/watcher#152
amesgen
force-pushed
the
amesgen/remove-custom-miso
branch
6 times, most recently
from
724b072
to
50eb6a6
Compare
|
ghcup PR was merged |
amesgen
force-pushed
the
amesgen/remove-custom-miso
branch
2 times, most recently
from
82d1667
to
d391ad3
Compare
amesgen
commented
Oct 25, 2024
cabal.project
Outdated
Comment on lines
6
to
7
| -- Required for TemplateHaskell. | ||
| shared: True |
There was a problem hiding this comment.
The nix builds don't need this because of the globally installed cabal.config, but ghcup does AFAICT (which is fine I think).
There was a problem hiding this comment.
I added
-- Required for TemplateHaskell. When using wasm32-wasi-cabal from
-- ghc-wasm-meta, this is superseded by the global cabal.config.
shared: True
amesgen
force-pushed
the
amesgen/remove-custom-miso
branch
from
d391ad3
to
562b7c2
Compare
amesgen
force-pushed
the
amesgen/remove-custom-miso
branch
from
562b7c2
to
6c355aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.