Added ability to toggle the Popover #721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded click handlers, in addition to touchend, for showing/hiding the popover.
…k without the ability to close
…wing programmatic showing/hiding of the popover.
|
I agree with you, it would be very useful if Ratchet have a global namespace for each Javascript components and have a public access for some methods. 👍 |
|
@mmacmillan: this needs to be cleaned up. Squashed etc. |
|
@XhmikosR yea, the code has evolved a bit beyond the PR; let me clean this up. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to toggle the popover by clicking/touching the link used to invoke it, a second time. This is useful for the case where a custom popover implementation doesn't leave much backdrop to click, hiding the popover...or when it is too far to travel for a click/touch. Added mouse click handlers for showing/hiding to facilitate web use-cases, and simple rapid-click protection that could cause the popover to get "stuck" open, without the ability to close.