feat!: allow retrieving all billing accounts and add billing_information column to gcp_project and gcp_organization_project tables #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
feat/gcp_project_billing
branch
from
7bee5fc
to
a44aa32
Compare
pdecat
force-pushed
the
feat/gcp_project_billing
branch
from
a44aa32
to
8857eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, submitted as draft to initiate a discussion.
The rationale of this PR is that a billing account is not tied to a single project.
Without this change, all existing billing accounts cannot be discovered.
Note: this PR is based on the branch of this other PR and thus includes the same commits. To ignore those in the changes view, select the last two commits: https://github.com/turbot/steampipe-plugin-gcp/pull/665/files/49ff495ed5572792b3dc5bdbbce989b613a83115..7bee5fc9dd846ca3d9d9e7ca9d21c90172c3a81b
Integration test logs
Logs
Example query results
Results