Fix issue where steampipe.spvars was not respected in a mod

internal/cmdconfig/app_specific.go

@@ -45,6 +45,7 @@ func SetAppSpecificConstants() {
 	app_specific.DefaultConfigPath = strings.Join([]string{".", globalConfigPath}, ":")
 
 	app_specific.DefaultVarsFileName = "powerpipe.ppvars"
+	app_specific.LegacyDefaultVarsFileName = "steampipe.spvars"
 	// default to local steampipe service
 	app_specific.DefaultDatabase = "postgres://[email protected]:9193/steampipe"
 

tests/acceptance/test_data/mods/test_workspace_mod_var_precedence_set_from_steampipe_spvars/README.md

@@ -0,0 +1,16 @@
+# test_workspace_mod_var_precedence_set_from_steampipe_spvars
+
+### Description
+
+This mod is used to test variable resolution precedence in a mod by passing a steampipe.spvars file. The mod also has a default value of variable 'version' set.
+
+### Usage
+
+This mod is used in the tests in `mod_vars.bats` to simulate a scenario where the version defined in the mod is picked from the steampipe.spvars over the default value of variable 'version' set in the mod, because steampipe.spvars have higher precendence.
+
+Steampipe loads variables in the following order, with later sources taking precedence over earlier ones:
+
+1. Environment variables
+2. The steampipe.spvars file, if present.
+3. Any *.auto.spvars files, in alphabetical order by filename.
+4. Any --var and --var-file options on the command line, in the order they are provided.

tests/acceptance/test_data/mods/test_workspace_mod_var_precedence_set_from_steampipe_spvars/mod.sp

@@ -0,0 +1,16 @@
+mod "test_vars_workspace_mod" {
+  title = "test_vars_workspace_mod"
+}
+
+query "version" {
+  sql = "select $1::text as reason, $1::text as resource, 'ok' as status"
+  param "p1"{
+    description = "p1"
+    default = var.version
+	}
+}
+
+variable "version"{
+	type = string
+	default = "v2.0.0"
+}

tests/acceptance/test_data/mods/test_workspace_mod_var_precedence_set_from_steampipe_spvars/steampipe.spvars

@@ -0,0 +1 @@
+version = "v7.0.0"

tests/acceptance/test_files/sp_files.bats

@@ -3,6 +3,21 @@ load "$LIB_BATS_SUPPORT/load.bash"
 
 ### spvars file tests ###
 
+@test "test variable resolution in workspace mod set from steampipe.spvars file" {
+  cd $FILE_PATH/test_data/mods/test_workspace_mod_var_precedence_set_from_steampipe_spvars
+
+  run powerpipe query run query.version --output csv
+  # check the output - query should use the value of variable set from the steampipe.spvars
+  # file ("v7.0.0") which will give the output:
+# +--------+----------+--------+
+# | reason | resource | status |
+# +--------+----------+--------+
+# | v7.0.0 | v7.0.0   | ok     |
+# +--------+----------+--------+
+  assert_output 'reason,resource,status
+v7.0.0,v7.0.0,ok'
+}
+
 @test "test variable resolution in workspace mod set from explicit spvars file" {
   cd $FILE_PATH/test_data/mods/test_workspace_mod_var_set_from_explicit_spvars