String ID support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushrax
approved these changes
Jan 15, 2024
| @@ -31,7 +31,7 @@ def __str__(self) -> str: | |||
| return f'tpuf-namespace:{self.name}' | |||
|
|
|||
| @overload | |||
| def upsert(self, ids: List[int], vectors: List[List[float]], attributes: Optional[Dict[str, List[Optional[str]]]] = None) -> None: | |||
| def upsert(self, ids: Union[List[int], List[str]], vectors: List[List[float]], attributes: Optional[Dict[str, List[Optional[str]]]] = None) -> None: | |||
There was a problem hiding this comment.
I like how the column oriented API makes it clear the IDs need to all be the same type
There was a problem hiding this comment.
Yep, that was a conscious decision to use over List[Union[int, str]]. The code doesn't enforce these annotations, but some user's linters might.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String ID support shipped today on the turbopuffer backend. This adds support for string IDs such as UUIDs.