add support for schema operations #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Gallant <[email protected]>
morgangallant
changed the title
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
|
@pushrax this PR now hinges on https://github.com/turbopuffer/turbopuffer/pull/1323, and the test should pass once thats merged/deployed. want to do this today! |
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
pushrax
approved these changes
Aug 15, 2024
turbopuffer/namespace.py
Outdated
| """ | ||
| request_payload = json.dumps({key: value.as_dict() for key, value in schema_updates.items()}).encode() | ||
| response = self.backend.make_api_request('vectors', self.name, 'schema', method='POST', payload=request_payload) | ||
| return parse_namespace_schema(response["content"]) |
There was a problem hiding this comment.
nit, kind of seems like these should be lower in the file, at least after exists()
Signed-off-by: Morgan Gallant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently only have the GET variant since PATCH isn't merged/deployed yet, will update this PR once that's in