Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pd.DataFrame support, remove dataclass_wizard #3

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

xthexder
Copy link
Contributor

@xthexder xthexder commented Jan 6, 2024

This PR includes some performance optimizations and bug fixes:

  • dataclass_wizard seemed to be adding unnecessary overhead to the object processing so it was removed.
  • pd.DataFrame is now natively supported (columns other than id and vector are automatically treated as attributes)
  • Fix VectorColumns.append(VectorRow) not handling attributes correctly
  • Lower default batch size to 5000 vectors to not hit request size limit (dynamic size checking is TODO)

@xthexder xthexder marked this pull request as ready for review January 13, 2024 01:04
@xthexder xthexder merged commit 2b7e086 into main Jan 13, 2024
4 checks passed
@xthexder xthexder deleted the pandas_support branch January 13, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant