Some smaller updates #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgangallant
changed the title
pushrax
reviewed
Jun 5, 2024
turbopuffer/namespace.py
Outdated
| @@ -175,7 +175,7 @@ def created_at(self) -> Optional[datetime]: | |||
| def upsert(self, | |||
| ids: Union[List[int], List[str]], | |||
| vectors: List[List[float]], | |||
| attributes: Optional[Dict[str, List[Optional[str]]]] = None, | |||
| attributes: Optional[Dict[str, List[Optional[str | int]]]] = None, | |||
There was a problem hiding this comment.
| isn't supported for union types on python 3.9, need to use Union[]
pushrax
reviewed
Jun 5, 2024
| [ | ||
| tpuf.VectorRow(id=8, vector=[0.8, 0.8], attributes={ "blabla": "row based upsert format is cool" }), | ||
| ], | ||
| schema=schema, |
There was a problem hiding this comment.
Even though this seems to work, we should also make sure all the overrides have the schema in the parameter list
fw42
approved these changes
Jun 6, 2024
|
Good catch. Sorry I missed this. |
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
morgangallant
force-pushed
the
mg/test-row-based-bm25-upsert
branch
from
4a66ece
to
4c56e97
Compare
Signed-off-by: Morgan Gallant <[email protected]>
|
@pushrax went ahead and bumped version to v0.1.13 in here, mind merging this + doing the publish after final review? Added the schema param to the upsert helpers too, I don't think this changed anything, but I agree it's the right thing to do! |
pushrax
approved these changes
Jun 6, 2024
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional[str]toOptional[str | int], we support numerical attribute types