Add data structure for NPF Content Blocks #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt the request tests to support NPF and Legacy * Add NPF API support to request client * Add first tests for ContentBlock serialization
…tible with PHP 7.0
Initialize User object + associated OwnBlog objects with the result of getUserInfo to make properties more accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer, I really like to get a very good idea about the hows and whats regarding the data I need to send to an API.
At this point either API documentation (e.g. OpenAPI, JSON API, etc.) or a very well structured client implementation provides the necessary insights.
This is why I want to propose a structure of PHP classes with typed properties for making the use of the API client more intuitive and easy to use - especially with the structural requirements and constraints introduced with NPF.
To further improve the developer experience for creating instances of the sometimes complex structures of NPF, a system of builder implementations additionally supporting this process will be introduced.
Disclaimer: This pull request is not yet ready for merge but should provide first insights into the ongoing development.
Please feel free to comment your ideas or critique 😁