Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish-to-s3 Gradle plugin to 0.9.0 #8

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

oguzkocer
Copy link
Collaborator

We added Android publishing block support to publish-to-s3 Gradle plugin in Automattic/publish-to-s3-gradle-plugin#31. With this change, we don't need the androidSourcesJar task anymore. It also addresses the following warning:

WARNING:Software Components will not be created automatically for Maven publishing from Android Gradle Plugin 8.0. To opt-in to the future behavior, set the Gradle property android.disableAutomaticComponentCreation=true in the gradle.properties file or use the new publishing DSL.

I am making this change to prepare the library for a future AGP 8.0 update, so releasing a new version is not necessary at the moment.

To Test

Verify that buildkite/permissme/publish-to-s3-maven CI job is successful

@oguzkocer oguzkocer requested review from a team and removed request for AliSoftware and ParaskP7 August 28, 2023 19:22
@oguzkocer oguzkocer merged commit 4605c69 into master Aug 29, 2023
2 checks passed
@AliSoftware AliSoftware deleted the update/publish-to-s3-plugin-to-0.9.0 branch August 29, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants