Fix handling of cookies for absolute domains #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, thanks for looking into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #42, other extensions might introduce additional cookies into the
youtube.comcookie space. There appears to be a difference between cookies which are readable from subdomains and cookies which can only be read from the domain that set it. The actual cookies set by YouTube all include subdomains, but the one set by Cookie AutoDelete does not.This causes the Python cookie file loader to fail, since it expects domains starting with a dot to match the subdomain flag (2nd flag in cookie file): https://github.com/python/cpython/blob/f46d8475749a0eadbc1f37079906a8e1ed5d56dc/Lib/http/cookiejar.py#L2050-L2051
I couldn't figure out, which exact format is represented here, but this commit fixes the browser plugin to respect the wishes of the underlying Python cookie jar.
Closes #42