Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop click propagating to elements behind download/subscribe buttons #40

Merged

Conversation

ritiek
Copy link
Contributor

@ritiek ritiek commented May 29, 2024

Fixes #39.

@ritiek ritiek force-pushed the stop-click-propagation-to-bg-elements branch from 03020d1 to 569e7ff Compare May 29, 2024 01:20
@ritiek ritiek changed the title Prevent click propagation to elements behind download button Stop click propagating to elements behind download/subscribe buttons May 29, 2024
@bbilly1
Copy link
Member

bbilly1 commented Jun 6, 2024

Interesting, new YT design, I haven't encountered this, at least so far.

I remember dealing with a similar problem with the little video button, but I didn't encounter the same problem on the channel button.

Anyway to force a change to test the new design so I can test this?

But then again, I don't see why this would cause a problem, as we wouldn't want to bubble up the event anyways.

@ritiek
Copy link
Contributor Author

ritiek commented Jun 6, 2024

I see, not sure how it works.

I was being treated with the new redesign here in India when browsing YouTube logged in through my Google account. I don't see it in incognito. Interestingly, I also don't see it now anymore after I logged out and logged in back into my Google account.

@Ogglord
Copy link

Ogglord commented Jun 7, 2024

Google is probably rolling out new designs for YT in specific regions, limited testing + limited risk.

@bbilly1
Copy link
Member

bbilly1 commented Jul 1, 2024

ok, let's go ahead with this, then if they ever roll this out, we are ready.

@bbilly1 bbilly1 merged commit 967a528 into tubearchivist:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping the download icon shouldn't open up video uploader's channel page in new YT redesign
3 participants