Add metric for number of active scanner renewers

This can be used to identify scanner leaks.
tsuna · Dec 31, 2024 · bed85a0 · bed85a0
1 parent 7492f7e
commit bed85a0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/prometheus.go b/prometheus.go
@@ -53,4 +53,12 @@ var (
 			4.096, 8.192, 13.192, 18.192, 23.192, 28.192, 33.192,
 		},
 	})
+
+	scanRenewers = promauto.NewGauge(prometheus.GaugeOpts{
+		Namespace: "gohbase",
+		Subsystem: "scanner",
+		Name:      "renewer_count",
+		Help: "Number of active scanner renewers. " +
+			"A continually increasing value indicates an Scanner leak.",
+	})
 )
diff --git a/scanner.go b/scanner.go
@@ -401,8 +401,12 @@ func (s *scanner) renew(ctx context.Context, startRow []byte) error {
 }
 
 func (s *scanner) renewLoop(ctx context.Context, startRow []byte) {
+	scanRenewers.Inc()
 	t := time.NewTicker(s.rpc.RenewInterval())
-	defer t.Stop()
+	defer func() {
+		t.Stop()
+		scanRenewers.Dec()
+	}()
 
 	for {
 		select {