-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use event syntax for particlesLoaded #31
Conversation
Should be all set now. Sorry for the trouble; this is pretty much my first time contributing to an external project. 😅 |
Don't worry, these are mainly questions to understand what has been done, the changes were minor fixes, nothing to worry about since the project was building and running |
I've changed the base branch, since this contains a breaking change and can't be released as a minor version. I have other plans for the major release as I said in the linked issue and this will be released there too. |
Perfect, thank you! |
Didn't know about this project, this is very interesting and could be good for the next major release. Instead of having @tsparticles/vue2 @tsparticles/vue3 packages, only @tsparticles/vue package could exist. |
I managed to write a proof-of-concept with this PR as a base using Apparently I replaced the Vite bundler with unjs/unbuild configured to simply copy the Vue SFC in-place. This is actually how most Vue component libraries work nowadays, regardless. |
Really nice, if you want to submit a PR targeting the |
Fixes #30.
Also cleaned up the two examples to remove dead code and use Nuxt best practices.