Add shapes_following_eyes raylib example #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkisor
reviewed
Feb 21, 2024
| @@ -60,6 +65,7 @@ bool build_native(void) | |||
| nob_cmd_append(&cmd, "-L./lib/", "-lraylib", "-lm"); | |||
| if (!nob_cmd_run_sync(cmd)) return 1; | |||
| } | |||
| return 0; | |||
There was a problem hiding this comment.
we don't actually do anything with the return value. (yet)
It would be cool to have it reflect in main's return.
That way something like ./nob && build/shapes_following_eyes will not try to run the executable if the build fails.
There was a problem hiding this comment.
I think it would be a good idea to handle this. I was getting compiler errors and that's why I added that return statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added yet another raylib example.
This implements:
and also adds various math functions to js:
This example uses DrawFPS, which is not implemented yet, so a TODO was added to raylib.js