[MRG] fix for issue #524 set max_attempts=1 when deterministic initial condition provided #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524
Bug occurs when a deterministic initial condition is specified in k-shape, rather than using random initialisation. If the initial condition supplied results in the EmptyClusterError being triggered ("Resumed because of empty cluster"), the model is fitted again with the same initial condition until max attempts = 10. As this initial condition is not random, the same result is achieved each time. This means the code is unnecessarily slow. Max_attempts cannot be controlled externally (line 207).
To fix this bug, code changed so that: max_attempts=1 when a deterministic initial condition is provided. Max_attempts still set the same way when a deterministic initial conditions is not provided.