Fix bug related to SoftDTWLossPytorch with option normalize=True when used on inputs of different lengths #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 67 67
Lines 5641 5641
=======================================
Hits 5239 5239
Misses 402 402 ☔ View full report in Codecov by Sentry. |
|
All checks have passed. |
…hs with option normalize=True
YannCabanes
changed the title
|
All checks have passed. |
YannCabanes
deleted the
fix-softdtwloss-normalized-for-different-lengths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #473 reporting an error message when
SoftDTWLossPytorchwith optionnormalize=Trueis used on inputs of different lengths.The bug is coming from the use of
torch.cat(https://pytorch.org/docs/stable/generated/torch.cat.html) which impose the lengths of the inputs to be equal. (The shape of the inputs is[batch_size, length, dim].)The use of
torch.catis removed in this PR.