Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix msmssweeps verification #2230

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

GertjanBisschop
Copy link
Member

Fixes the bugs in #2229. Also updates the download link for msms which was out of date.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2230 (0a50c26) into main (4c80801) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2230   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          20       20           
  Lines       11334    11334           
  Branches     2302     2302           
=======================================
  Hits        10373    10373           
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.52% <ø> (ø)
python 98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c80801...0a50c26. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just delete the old code

verification.py Outdated
mutation.position / msms_params["num_sites"]
for mutation in tree_sequence.mutations()
]
# positions = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete this

@mergify mergify bot merged commit 11615e0 into tskit-dev:main Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants