Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for thematic breaks/dividers in markdown parsing #61

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

sengmitnick
Copy link
Contributor

This commit adds support for thematic breaks/dividers in the markdown parsing functionality. It introduces a new function divider() in the blocks.ts file, which creates a divider block. Additionally, the parseNode() function in the internal.ts file has been updated to handle the thematicBreak node type and convert it into a divider block.

This commit adds support for thematic breaks/dividers in the markdown parsing functionality. It introduces a new function `divider()` in the `blocks.ts` file, which creates a divider block. Additionally, the `parseNode()` function in the `internal.ts` file has been updated to handle the `thematicBreak` node type and convert it into a divider block.
Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@EndBug
Copy link
Member

EndBug commented Jun 25, 2024

Tests are failing though 👀

@sengmitnick
Copy link
Contributor Author

Oops, missed a test change, fixed that.

@EndBug
Copy link
Member

EndBug commented Aug 1, 2024

Awesome! Thanks for the PR 🚀

@EndBug EndBug merged commit dfae74c into tryfabric:master Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants