Upgrade dependencies, most important to utoipa 5, dropping a bunch of workarounds #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure we process all the settings fields, we destructure them.
ctron
force-pushed
the
feature/update_deps_5
branch
from
bb84d08
to
aa3b4a7
Compare
|
@chirino @carlosthe19916 not sure this has an impact in the UI side of things. |
ctron
force-pushed
the
feature/update_deps_5
branch
from
aa3b4a7
to
f06e4d1
Compare
|
I can see the openapi.yaml will change a bit. I don't see too many changes though (it is something I can manage). I think it should not be a blocker for the UI. So those changes should be fine |
ctron
force-pushed
the
feature/update_deps_5
branch
from
f06e4d1
to
6eca0c5
Compare
ctron
force-pushed
the
feature/update_deps_5
branch
from
6eca0c5
to
22a2739
Compare
jcrossley3
reviewed
Oct 30, 2024
By leveraging utoipa_actix_web, this change removes the hand-crafted collection of openapi operations, and let utoipa collect this during the creation of the actix web `App`. This results in the actual spec, and removes the need to keep this aligned with the `openapi` functions we had. The downside is, that the `xtask` now needs to construct a full `App` instance. Which isn't a big deal, but requires an embedded database to the instantiated. However, we do this for running tests too. This also already fixed an missing operation.
|
@jcrossley3 I'll work through the comments. In the meantime, I pushed some more changes. Which gets rid of the manually collected openapi spec altogether and uses the actually registered handlers to construct it. |
jcrossley3
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few dependencies. Most notably to utoipa 5, which now supports nesting of specs, and generic type arguments. Allowing us to drop some workarounds we had in place. It also auto-collects schemas now.