Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a few more Into<Purl>'s hither and yon. #86

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

bobmcwhirter
Copy link
Contributor

Add type constraints to make using transactions a bit easier. A Transactional::Some(_) owns its transaction, reducing the things you need to hang onto.
A Transactional::Some(_) is provided ready-to-eat from Graph::transaction(). A () can be used for non-transactional as shorthand for Transactional::None.

Bob McWhirter added 2 commits March 15, 2024 15:03
Add type constraints to make using transactions a bit easier.
A `Transactional::Some(_)` owns its transaction, reducing the things
you need to hang onto.
A `Transactional::Some(_)` is provided ready-to-eat from Graph::transaction().
A `()` can be used for non-transactional as shorthand for `Transactional::None`.
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you did this! All the anonymous lifetimes were a tad smelly.

@bobmcwhirter bobmcwhirter merged commit 1334639 into trustification:main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants