-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] - ci: integrate with global ci #857
Conversation
what is a global test ?
I'm ok with this |
@carlosthe19916 thanks! I don't have a strong opinion on the With this, I think all that's left is to deploy the image built by |
It would be a test that run against an instance of our project when all the pieces are all together, just like what you would expect to have if we were to release the project with what we have right now. Just to give an example: currently this repository has nice tests but they are limited to test the backend, it does not test whether or not the backend actually breaks something in the UI. So the idea is to be able to test an instance that is as close as possible to what the customers will actually get when he uses our project. I mean, test production mode no dev mode artifacts. |
yeah I agree, I think I asked wrong... |
I'll probably say nonsense but I think there are two different problems and each one will have a different solution:
This is just an idea. I personally do not support creating ArgoCD or things like that for deploying since it adds a new thing to maintain. |
I'm still now understanding where I should configure/call those 2 TS and Java tests /me feeling dumb again |
My apologies if I contributed to the confusion. |
No worries I just left a different context 👍
👍 |
Not sure if we still consider this PR for merging at some point. If not, let's close it. |
This PR served as a model for the |
@jcrossley3 @helio-frota this PR is just to show how to integrate this repo with the global tests https://github.com/trustification/trustify-ui-tests and https://github.com/trustification/trustify-api-tests
For each PR the tests will be executed.
This is a draft as you guys should find the appropriate way of creating the container images. I like to do it with Dockerfiles but it might not be what you guys prefer so I'll leave that to you.
The only purpose of this PR is to showcase how to make this repo run tests globally. Although as of today the repositories https://github.com/trustification/trustify-ui-tests and https://github.com/trustification/trustify-api-tests
do not have significant tests written there yet, but once I get into the UI work I should personally pay more attention to create UI e2e tests and enrich the https://github.com/trustification/trustify-ui-tests repo.