Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Rust to 1.80.1, update garage-door #719

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Aug 28, 2024

Pre-req of #703

This also updates garage-door in order to work around trustification/trustify-ui#145

@ctron ctron requested a review from helio-frota August 28, 2024 07:22
Required by trustification#703

This also requires us to drop the "mock" feature cfg. It currently is
an undeclared feature, which is a warning now, and might become an error
later.

Declaring that feature and mapping it to `sea-orm/mock` would be the
right thing to do. However, sea-orm will drop the `Clone` implementation
of the connection trait in the case the mock feature is enabled. And
our database struct requires the connection trait to be `Clone`.
Meaning, that we don't support the `mock` feature anyway.
@ctron ctron requested a review from dejanb August 28, 2024 08:51
@ctron ctron changed the title build: update Rust to 1.80.1 build: update Rust to 1.80.1, update garage-door Aug 28, 2024
@ctron ctron enabled auto-merge August 28, 2024 09:40
Copy link
Collaborator

@helio-frota helio-frota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this 👍
2024-08-28_07-23

I was trying to understand why we are having (not using yet) it...

probably mock is weird for the amount of data we have
https://github.com/martelinho-de-ouro/moria-watcher/blob/39a1b1de5f9070490b213b016f74a19242b88879/service/tests/prepare.rs#L13-L47

@ctron ctron added this pull request to the merge queue Aug 28, 2024
Merged via the queue into trustification:main with commit 0a3bb4c Aug 28, 2024
1 check passed
@ctron ctron deleted the feature/update_rust_1 branch August 28, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants