-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused things #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing a lot more than just "removing unused things". Let's start by just removing all the unused imports.
I'm curious, though: what's the reason for all the #[allow(dead_code)]
and TODO
comments?
I agree. I'm using
Good question 👍 Due to the experimental appearance of the code (in some parts), I preferred to use dead_code for struct attributes and All these points appeared after I removed the imports and
|
Reading again the issue I got the thing... we are not kind of prepared to remove this part I'll add back |
* focusing on graph dir only
@jcrossley3 PR updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@jcrossley3 thanks! |
Related to #17